meshery/meshery

[mesheryctl] UX: Need more informative inactive token message

Open

#4,604 opened on Nov 11, 2021

View on GitHubContributor guide
 (22 comments) (0 reactions) (0 assignees)HTML (3,101 forks)batch import
area/uxcomponent/mesheryctlhelp wantedissue/remindissue/willfixkind/enhancementlanguage/go

Repository metrics

Stars
 (10,013 stars)
PR merge metrics
 (Avg merge 22d 16h) (332 merged PRs in 30d)

Description

See mesheryctl Command Tracker for current status of commands.

Current Behavior

Users of mesheryctl perf profile, who don't have an active token receive the following message:

➜  ~ mesheryctl perf profile
Error: failed to make a request.Get "/": stopped after 10 redirects.
See https://docs.meshery.io/reference/mesheryctl/perf/profile for usage details

This behavior is true of a number of other commands. Each of the app, pattern, mesh, perf`.... should all apply the same logic and UX to the user - https://github.com/meshery/meshery/blob/2bf19d36cfd924c9c2e07fbb8686c975689309c5/mesheryctl/internal/cli/root/system/check.go#L489

Desired Behavior

Users should be informed of their inactive token and informed to run mesheryctl system login.

Acceptance Tests

  • 1. All perf commands apply this same check and UX.
  • 2. All mesh commands apply this same check and UX.
  • 3. All app commands apply this same check and UX.
  • 4. All pattern commands apply this same check and UX.

Contributor Resources

Contributor guide

Research direction
Check the existing token validation logic in check.go and apply similar checks across all perf, mesh, app, pattern commands.
Tech stack
go
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80