meilisearch/MeiliSearch

download-latest.sh: return an error when the musl C library is present on the machine

Open

#4,379 opened on Jan 31, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Rust (2,542 forks)batch import
contribution acceptedenhancementgood first issuetooling

Repository metrics

Stars
 (57,572 stars)
PR merge metrics
 (Avg merge 11d 20h) (41 merged PRs in 30d)

Description

Meilisearch binary attached to the release cannot work with musl C library, like we can have with Alpine Linux.

The issue is, the download-latest.sh script does not return an error when we use it on a machine where musl C library is present.

We might want to return an equivalent of this error

Contributor guide

Research direction
Add detection for the musl C library in the download latest.sh script. Check the official musl detection methods (e.g., using `ldd version` or checking /lib/ld musl *). Return an error similar to the existing error for glibc detection on line 102-106 of the same file.
Tech stack
shell
Domain
devops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70