meilisearch/MeiliSearch

Improve GitHub CI manifest: remove useless `matrix`?

Open

#2,891 opened on Oct 11, 2022

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)Rust (2,542 forks)batch import
contribution acceptedgithub actionshelp wantedmaintenanceOLD

Repository metrics

Stars
 (57,572 stars)
PR merge metrics
 (Avg merge 11d 20h) (41 merged PRs in 30d)

Description

In this manifest file, we have two jobs we could maybe refactor

The issue with both of these jobs is they ar using matrix without using the real purpose of matrix, I mean, running multiple times the same job with different contexts described in the matrix. Here the matrix are arrays of 1 single element.

I wanted to know if it would be possible to have the same job working without matrix BUT ⚠️ ⚠️

  • I don't want the information to be hard written in the job: I like the face we have all the information at top of the job
  • It means I want an alternative only if it exits a GitHub action way to declare kind of variables available for the job, at the top of the job

Maybe matrix is the best solution, in this case, I cannot ensure we will merge your PR if you suggest something.

Thanks in advance for your help ❤️

Contributor guide

Research direction
Inspect the publish binaries.yml workflow, identify the two jobs using single element matrices, and propose a refactored version using job level variables or a different approach while preserving readability.
Tech stack
github actions
Domain
ci cd
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75