meilisearch/MeiliSearch

Enable LTO again

Open

#2,718 opened on Aug 29, 2022

View on GitHubContributor guide
 (7 comments) (1 reaction) (0 assignees)Rust (2,542 forks)batch import
enhancementhelp wantedperformancetech discussion

Repository metrics

Stars
 (57,572 stars)
PR merge metrics
 (Avg merge 11d 20h) (41 merged PRs in 30d)

Description

We first enabled LTO in this PR https://github.com/meilisearch/meilisearch/pull/2690 to improve the performance of the search engine.

Then, we had to disable LTO in this PR https://github.com/meilisearch/meilisearch/pull/2717 because we were not able to compile the aarch64 binary anymore. See: https://github.com/meilisearch/meilisearch/actions/runs/2948932141

We would introduce LTO again and prevent using it when compiling the aarch64 binary. Some beginning of solution here

If anyone has a better solution, we would happy to read you!

Contributor guide

Research direction
Research how to conditionally enable LTO only for non aarch64 targets in Rust. Look into Cargo build scripts or conditional compilation using `cfg` attributes. Consider using `#[cfg(target arch = "aarch64")]` to disable LTO for that architecture.
Tech stack
rust
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65