meilisearch/MeiliSearch

Fix the dump import tests on windows

Open

#2,364 opened on May 3, 2022

View on GitHubContributor guide
 (3 comments) (1 reaction) (0 assignees)Rust (2,542 forks)batch import
contribution acceptedgood first issuehelp wantedmaintenanceversion upgradewindows

Repository metrics

Stars
 (57,572 stars)
PR merge metrics
 (Avg merge 11d 20h) (41 merged PRs in 30d)

Description

Windows throw errors when we try to read a dump in the CI (maybe that actually happens everywhere?). See the following action: https://github.com/meilisearch/meilisearch/runs/6215426608?check_suite_focus=true

This could be related to this issue in which case we can't do anything about it.

For now, we ignore all the tests when running on windows.

Contributor guide

Research direction
Investigate the cause of the Windows test failures by inspecting the CI logs and the dump import code. Consider whether the issue is due to file locking on Windows and explore workarounds such as using temporary files or ensuring proper cleanup.
Tech stack
rust
Domain
backendtesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75