meilisearch/MeiliSearch

Update docker image to expose `meilisearch` as the entry point rather than `tini`

Open

#2,229 opened on Mar 13, 2022

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)Rust (2,542 forks)batch import
help wantedtooling

Repository metrics

Stars
 (57,572 stars)
PR merge metrics
 (Avg merge 11d 20h) (41 merged PRs in 30d)

Description

Currently, Meilisearch exposes tini as the dockerfile entry point.

This creates a rather cryptic error when you try to run meili like normal e.g.

& docker run --name meilisearch -p 7700:7700 getmeili/meilisearch --master-key="foobar"

Produces:

[FATAL tini (7)] exec --master-key=foobar failed: No such file or directory

Which isn't the most helpful error in the world.

Either that or the documentation probably want's to be changed slightly to make it more clear that you need to explicitly re-run meili as:

& docker run --name meilisearch -p 7700:7700 getmeili/meilisearch ./meilisearch --master-key="foobar"

But IMO

getmeili/meilisearch ./meilisearch --master-key="foobar"

Doesn't seem to be the best situation.

Contributor guide

Research direction
Look at the current Dockerfile and change the ENTRYPOINT from tini to the meilisearch binary. Ensure the binary path is correct and that arguments pass through properly.
Tech stack
rustdocker
Domain
devopsinfrastructure
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DockerBasic shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85