matthewbub/lg-coffee

refactor: fs-extra command should use copySync() instead of moveSync()

Open

#82 opened on Nov 23, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (2 forks)auto 404
good first issuehelp wantedjavascriptnodejs

Repository metrics

Stars
 (0 stars)
PR merge metrics
 (PR metrics pending)

Description

Referring to the command used to build the directory on local.

https://github.com/hi-matbub/lg-coffee/blob/0b89db809a112e384f79f56b39b33c4d0a7f8135/packages/lg-init/index.js#L60-L71

Reason for this is for those who decide to save this command vs using npx.

Recreate on a local environment :wrench:

run npx path_to/lg-coffee/packages/lg-init/index.js

after completing the prompts notice the og directory has been moved out of lg-coffee/packages/lg-init/lib/templates

Possible Solution 💡

we are using fs-extra and I'm blindly betting on .copySync() being the best solution here.

Contributor guide

Research direction
Replace `moveSync()` with `copySync()` in the command that builds the directory, ensuring the source directory remains intact.
Tech stack
javascriptnodejs
Domain
clideveloper experience
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsfs extra
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75