matrix-org/dendrite

Move db-level SQL statements to the file which implements the storage interface

Open

#963 opened on Apr 14, 2020

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Go (658 forks)auto 404
T-Taskgood first issue

Repository metrics

Stars
 (5,632 stars)
PR merge metrics
 (PR metrics pending)

Description

In several places for postgres, we CREATE SEQUENCE .... We do this for every table which uses the sequence, partly for clarity and partly so we don't assume someone else has done it for us.

Instead, we should put these database-level SQL queries in a dedicated section, rather than in each _table.go.

Contributor guide

Research direction
Identify all CREATE SEQUENCE statements in postgres table.go files and consolidate them into a dedicated file for database initialization.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70