matrix-org/dendrite

Update Sentry reporting further

Open

#3,306 opened on Jan 18, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Go (658 forks)auto 404
T-Taskgood first issue

Repository metrics

Stars
 (5,632 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/matrix-org/dendrite/pull/3305 made reporting errors a bit better, but there are still places in the code where we CaptureException in go routines, possibly still sending garbage to Sentry. For reference: https://docs.sentry.io/platforms/go/usage/concurrency/

It may also make sense to check if we even should report said errors to sentry, as e.g. we should always be able json.Unmarshal things we sent to JetStream ourselves.

Contributor guide

Research direction
Identify goroutines in the codebase that call sentry.CaptureException and evaluate whether the error should be reported. Also check if the error is from JetStream unmarshaling and skip reporting in that case.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65