matrix-org/dendrite

Get IP from "standard" HTTP headers

Open

#3,287 opened on Dec 15, 2023

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Go (658 forks)auto 404
T-Enhancementgood first issuehelp wanted

Repository metrics

Stars
 (5,632 stars)
PR merge metrics
 (PR metrics pending)

Description

...

But, if I may, do you think Dendrite should perhaps auto-try any of the standard "this is the client's real IP" headers automatically? Do you see any downsides in doing that? For what it's worth, from my limited self-hosting experience, many applications do it automatically, given the current trends in hosting stuff (everything behind reverse proxy or ingress or whatever)

Best regards Zbig

Originally posted by @zbig-t in https://github.com/matrix-org/dendrite/issues/3286#issuecomment-1853767516

Contributor guide

Research direction
Investigate how Dendrite currently extracts client IPs, identify relevant code locations, and research standard HTTP headers (e.g., X Forwarded For, X Real IP) to determine best practices for automatic detection.
Tech stack
go
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoHTTP basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75