matrix-org/dendrite

Fix failing /sync tests

Open

#1,324 opened on Aug 24, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (658 forks)auto 404
C-Sync-APIT-Defectare-we-synapse-yethelp wanted

Repository metrics

Stars
 (5,632 stars)
PR merge metrics
 (PR metrics pending)

Description

They should be passing but for some reason are not.

Sytests:

    × Newly joined room has correct timeline in incremental sync
    × Newly joined room includes presence in incremental sync
    × When user joins a room the state is included in the next sync
    × When user joins a room the state is included in a gapped sync
    × When user joins and leaves a room in the same batch, the full state is still included in the next sync
    × Current state appears in timeline in private history with many messages after

Contributor guide

Research direction
Run the failing sytest tests and trace the sync handler logic in dendrite to identify why newly joined room state is not correctly included in incremental sync.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoMatrix sync API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50