mapbox/mapbox-gl-redux

Remove special case code

Open

#9 opened on May 18, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (3 forks)github user discovery
good first issue

Repository metrics

Stars
 (37 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There's functionality that made sense in Mapbox Studio but less so here as a broad utility:

https://github.com/mapbox/mapbox-gl-redux/blob/435c286e6397ff0febb59a94b4558ffbc22a3ad1/src/index.js#L38-L47

If there isn't a good case for keeping it around we should remove it.

Contributor guide

Research direction
Examine lines 38-47 in src/index.js and verify if the special case functionality is still necessary; if not, remove the code and ensure tests pass.
Tech stack
javascript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90