mapbox/mapbox-gl-directions

Tests should fail more gracefully if access token is not set

Open

#152 opened on Oct 20, 2017

View on GitHubContributor guide
 (0 comments) (1 reaction) (0 assignees)JavaScript (130 forks)github user discovery
good first issue

Repository metrics

Stars
 (253 stars)
PR merge metrics
 (Avg merge 22h 39m) (1 merged PR in 30d)

Description

When you run npm test without setting the your access token in your local environment, you get the following error:

# directions
# initialized
ok 1 directions is initialized
# set/get inputs
not ok - Uncaught, unspecified "error" event. ([object Object])
http://localhost:58414/script.js:2069
        var err = new Error('Uncaught, unspecified "error" event. (' + er + ')');

It should instead tell you that you're missing your access token.

Contributor guide

Research direction
In the test setup file, add a check for the MAPBOX ACCESS TOKEN environment variable and if not set, throw a descriptive error message instructing the user on how to set it.
Tech stack
javascript
Domain
apitesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85