mapbox/carto

Nested regex can cause extremely slow generation times and longer xml

Open

#213 opened on Dec 13, 2012

View on GitHubContributor guide
 (13 comments) (0 reactions) (0 assignees)JavaScript (132 forks)auto 404
bughelp wantedperformance

Repository metrics

Stars
 (658 stars)
PR merge metrics
 (PR metrics pending)

Description

As a particularly noticeable example is the TileMill example open-streets-dc where converting two sections with the widths to regex, or even just changing a few lines from = to =~ gives significantly different results. https://github.com/tilemill-project/tilemill/blob/master/examples/open-streets-dc/highway.mss#L119 is an example line to change to get the difference.

I'm using Carto 0.9.4.

Contributor guide

Research direction
Investigate the regex patterns causing slow generation times and identify optimizations to reduce generation time and XML output size.
Tech stack
javascript
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCarto
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70