ly525/luban-h5

辅助线的参考数组应该排除‘lbp-background’组件

Open

#163 opened on May 16, 2020

View on GitHubContributor guide
 (3 comments) (0 reactions) (1 assignee)JavaScript (1,278 forks)batch import
enhancementfeaturehelp wanted

Repository metrics

Stars
 (6,239 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

const referElements = this.elements.filter(e => e.uuid !== uuid)

可以改为

  const referElements = this.elements.filter(e => e.uuid !== uuid && e.name !== 'lbp-background')

否则会出现无意义的辅助对齐线

Contributor guide

Research direction
Locate the `referElements` filter in the codebase and add the condition `e.name !== 'lbp background'` to exclude the background component from alignment guides.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80