lobsters/lobsters

Update Specs to current style

Open

#704 opened on Jul 13, 2019

 (2 comments) (0 reactions) (0 assignees)Ruby (961 forks)user submission
dependenciesfeaturereqgood first issue

Repository metrics

Stars
 (4,680 stars)
PR merge metrics
 (Avg merge 7d 4h) (20 merged PRs in 30d)

Description

I've been reading through rspec-rails documentation.

I found 2 interesting things that relate to the lobsters code base:

According to https://github.com/rspec/rspec-rails#request-specs

Rails and RSpec teams discourage directly testing controllers in favor of functional tests like request specs

Should lobsters follow this advice and accept only request specs in the future and have a migration ticket to move controller specs to request specs?

Another similar question that is a little bit less obvious from https://github.com/rspec/rspec-rails#feature-specs

Before Rails introduced system testing facilities, feature specs were the only spec type for end-to-end testing. While the RSpec team now officially recommends system specs instead, feature specs are still fully supported, look basically identical, and work on older versions of Rails.

On the other hand, feature specs require non-trivial configuration to get some important features working, like JavaScript testing or making sure each test runs with a fresh DB state. With system specs, this configuration is provided out-of-the-box.

Should we open an issue to migrate existing feature specs to system specs and only accept system specs moving forward?

Contributor guide