llvm/llvm-project

`std::filesystem::canonical("")` should throw

Open

#77,170 opened on Jan 6, 2024

View on GitHubContributor guide
 (7 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
filesystemgood first issuelibc++

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

Per fs.op.canonical, !exists(p) is an error. However, calling canonical("") returns the current path instead of raising an exception.

Tested with Apple clang version 15.0.0 (clang-1500.1.0.2.5) and -std=c++17.

Contributor guide

Research direction
Investigate the implementation of `std::filesystem::canonical` in libc++ and ensure an exception is thrown for empty path per the standard.
Tech stack
cpp
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60