llvm/llvm-project

readability check to convert numerical constants to std::numeric_limits

Open

#34,434 opened on Oct 25, 2017

View on GitHubContributor guide
 (14 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
bugzillacheck-requestclang-tidyconfirmedgood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description
Bugzilla Link 35086
Version unspecified
OS All
CC @JonasToth

Extended Description

It'll be great to have readability check with will convert ~0, -1 for unsigned integer types to std::numeric_limits::max().

Contributor guide

Research direction
Study existing clang tidy readability checks (e.g., readability identifier naming) to understand the structure. Use AST matchers to detect patterns like integer literal 1 or ~0 assigned to unsigned types. Then emit a fix it hint to replace with std::numeric limits<type>::max(). Look at the clang tidy documentation for creating checks.
Tech stack
cpp
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++clang tidy basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75