ljharb/qs

Arrays parsed incorrectly

Open

#288 opened on Nov 27, 2018

View on GitHubContributor guide
 (3 comments) (3 reactions) (0 assignees)JavaScript (898 forks)batch import
feature requesthelp wantedparse

Repository metrics

Stars
 (8,942 stars)
PR merge metrics
 (Avg merge 6d 22h) (2 merged PRs in 30d)

Description

Hi, I have this object:

const filter = {
  3: [{ name: 'Test', id: 50753 }, { name: 'Test2', id: 48464 }],
  6: ['2018-11-01', '2018-11-02']
}

I call stringify and parse

const stringifyQuery = Qs.stringify(filter, { arrayFormat: 'brackets' })
const parseQuery = Qs.parse(stringifyQuery, { arrayLimit: 0 })

Result parse: Key '3' contains only 1 element instead of 2. And this element contains the merged keys name, id:

3: Array(1)
  0:
    id: (2) ["50753", "48464"]
    name: (2) ["Test", "Test2"]

I expect:

3: Array(2)
  0: {name: "Test", id: 50753}
  1: {name: "Test2", id: 48464}

Please help me https://codepen.io/anon/pen/rQrqXx

Contributor guide

Research direction
Investigate the parsing logic in the qs library when arrayFormat is 'brackets' and arrayLimit is 0. Focus on how nested objects within arrays are being merged incorrectly.
Tech stack
javascript
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75