linebender/parley

Use `FromStr` rather than `fn parse`

Open

#98 opened on Jul 30, 2024

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Rust (92 forks)github user discovery
good first issuehelp wanted

Repository metrics

Stars
 (620 stars)
PR merge metrics
 (Avg merge 19d 11h) (38 merged PRs in 30d)

Description

In fontique there are some methods parse which could instead use FromStr and be able to use the str::parse function as detailed here: https://doc.rust-lang.org/std/primitive.str.html#method.parse

These methods are:

  • GenericFamily::parse()
  • Stretch::parse()
  • Style::parse()
  • Weight::parse()

This was suggested by @DJMcNab in #97.

Contributor guide

Research direction
Implement the FromStr trait for GenericFamily, Stretch, Style, and Weight. Replace the existing parse methods with str::parse calls.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75