lexrus/LTFinderButtons

Won't work if the path contains Chinese.

Open

#15 opened on Jul 9, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rich Text Format (20 forks)github user discovery
help wanted

Repository metrics

Stars
 (313 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When TerminalFinderButton was pressed, if directory ~/tem/测试 was selected, terminal will show following error:

$ cd "/Users/koc/tem/æµ^Ëè¯^Õ/";clear; cd: no such file or directory: /Users/koc/tem/æµ\M-^Kè¯\M-^U/

Contributor guide

Research direction
Check how the path is being converted to a string for the terminal command. Ensure the path is properly escaped using NSFileManager's stringByAddingPercentEncodingWithAllowedCharacters or equivalent.
Tech stack
objective cshell
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
File path encoding concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60