lenra-io/lenra_components

Is 'utils' belongs to this library ?

Open

#7 opened on Aug 18, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Dart (0 forks)auto 404
help wantedinvalidquestion

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

There is a folder 'utils' that give some helpers to :

  • parse a color
  • validate textfield input (password/email)

The color parser is not used by the library. It is just exposed as part of the lib. The validator is partially used by the lenra_text_form_field.dart component to check the value of the input based of the type parameter (email or password).

I think we can safely remove the color parser but i'm not sure about the validator :

  • Is it our job to check the value of the input ? If not, we should remove the validator.
  • If it is our job, we should provide a way for the user to completely override the validator (not just add on top of the existing validator).
  • Should we add more types in the futur ? (phone number, address...)

@lenra-io/lenra any thought ?

Contributor guide

Research direction
Analyze the usage of the utils folder components (color parser and validator) within the library and externally. Decide whether to remove the color parser, refactor the validator to allow full override, or extract utilities into a separate package. Consider the library's scope and future plans.
Tech stack
dartflutter
Domain
frontendmobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
DartFlutter
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50