leboncoin/spark-android

[FR]: Fix theming.md dim-level examples to show composable context

Open

#2,113 opened on Jul 27, 2026

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Kotlin (31 forks)auto 404
contribution welcomeddocumentationgood first issuepriority:MEDIUM

Repository metrics

Stars
 (85 stars)
PR merge metrics
 (Avg merge 4d 9h) (73 merged PRs in 30d)

Description

Describe the problem

The "Dim levels" section in theming.md shows code like:

val disabledColour = SparkTheme.colors.onSurface.disabled

Both .disabled and .dim2 are @Composable getters. The code shown has no @Composable context and will not compile.

Describe the solution

Wrap the examples in a @Composable function or show the properties used inside a composable body.

Additional context

Priority: Medium. Effort: XS.

Contributor guide

Research direction
Add a @Composable wrapper around the examples in theming.md to show proper context.
Tech stack
kotlin
Domain
mobile
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Kotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90