laravel/pint

Asymmetric Visibility Issue

Closed

#383 opened on Jul 18, 2025

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)PHP (189 forks)user submission
help wanted

Repository metrics

Stars
 (3,127 stars)
PR merge metrics
 (Avg merge 2d 1h) (12 merged PRs in 30d)

Description

Pint Version

1.24.0

PHP Version

8.4

Description

There seems to be a bug with how asymmetric visibility is handled. The following class properties are fine:

  • public private(set) int $concurrency;
  • private int $concurrency;

However if I try to use the abbreviated form private(set) int $concurrency; as specified in the RFC then I get the error Cannot access offset of type null on SplFixedArray

Steps To Reproduce

Set a class property like private(set) int $propertyName and then run pint on the file.

Contributor guide

Research direction
Investigate the bug by examining how Pint parses property modifiers, specifically the handling of `private(set)` without explicit visibility. Look at the grammar file or lexer (likely in `src/` directory) that tokenizes and parses property declarations. The single comment on the issue may provide additional clues. Test with the provided reproduction case and ensure the fix aligns with the PHP RFC on asymmetric visibility.
Tech stack
php
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP 8.4asymmetric visibility syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35