langgenius/dify

[Chore/Refactor] db.session.xxx -> with Session as session

Closed

#24,115 opened on Aug 18, 2025

View on GitHubContributor guide
 (12 comments) (1 reaction) (0 assignees)TypeScript (22,210 forks)batch import
good first issue

Repository metrics

Stars
 (141,412 stars)
PR merge metrics
 (Avg merge 1d 21h) (579 merged PRs in 30d)

Description

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

db.session.commit() is Flask-SQLAlchemy

with Session(...) is Pure SQLAlchemy

Motivation

for migration.

Additional Context

https://docs.sqlalchemy.org/en/20/orm/session_basics.html#framing-out-a-begin-commit-rollback-block

part of COM-7832

need https://github.com/facebook/pyrefly/issues/954

one example: #24135

Contributor guide

Research direction
Replace all occurrences of db.session.commit() and db.session.rollback() with 'with Session as session' pattern. See #24135 for a concrete example. The pyrefly issue referenced is a prerequisite. Focus on Dify's Python backend code; search for 'db.session' in the codebase to find relevant files.
Tech stack
pythonsql
Domain
backenddatabase
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SQLAlchemy basicsFlask SQLAlchemy familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50