langgenius/dify

improve dict check in py

Closed

#22,651 opened on Jul 18, 2025

View on GitHubContributor guide
 (15 comments) (2 reactions) (2 assignees)TypeScript (22,210 forks)batch import
good first issueno-issue-activity💪 enhancement

Repository metrics

Stars
 (141,412 stars)
PR merge metrics
 (Avg merge 1d 21h) (579 merged PRs in 30d)

Description

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

now a lot of type is bare dict

rg ": dict\)" --glob "*.py" | wc -l
165

use pydantic can reduce many dup pattern like

if not field:
    raise ValueError...

example #24837

2. Additional context or comments

https://lexi-lambda.github.io/blog/2019/11/05/parse-don-t-validate/

3. Can you help us with this feature?

  • I am interested in contributing to this feature.

Contributor guide

Research direction
Identify all occurrences of bare dict types in Python files using the grep command provided. Study existing Pydantic models (e.g., from issue #24837) to understand the pattern, then replace bare dicts with appropriate Pydantic models ensuring proper validation. Coordinate with the two assignees to avoid duplication and align on scope.
Tech stack
python
Domain
backenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPydantic basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20