kubernetes/minikube

move viper calls from packages into cmd to improve testability/resusablitily

Open

#21,670 opened on Sep 30, 2025

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Go (5,222 forks)batch import
help wantedkind/cleanuppriority/important-soon

Repository metrics

Stars
 (31,799 stars)
PR merge metrics
 (Avg merge 26d 4h) (55 merged PRs in 30d)

Description

packages inside minikube should not be calling viper to get a config, the viper (getting confg flags) should only be called form Cmd packages

this will help better testing and also avoid race conditions in Setting or Getting Flags in Parallel testing and Parallel usage of minikube and make minikube code more reusable and more testable

Originally posted by @medyagh in https://github.com/kubernetes/minikube/pull/21635#discussion_r2392461773

Contributor guide

Research direction
Identify all functions in non cmd packages that call viper.Get* or viper.Set* and move them to cmd packages, passing configuration as parameters.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGoViper
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70