kubernetes/ingress-nginx

Support standard Forwarded header

Open

#10,263 opened on Aug 1, 2023

View on GitHubContributor guide
 (15 comments) (9 reactions) (2 assignees)Go (7,888 forks)batch import
good first issuehelp wantedkind/featurepriority/backlogtriage/accepted

Repository metrics

Stars
 (15,199 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As far as I can see the ingess controller currently just supports the "non-standard" X-Forwarded-* headers. It would be nice to support also the standard Forwarded header.

Use case

Keycloak has added support for the Forwarded header with version 21.0.0 and advices reverse-proxies to override this header.

Contributor guide

Research direction
Investigate how the ingress controller currently parses X Forwarded * headers in the NGINX configuration templates and Go code. Add logic to parse and apply the standard Forwarded header, following the spec (RFC 7239). Update tests and documentation accordingly.
Tech stack
go
Domain
apibackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoHTTPKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65