kubernetes-sigs/aws-load-balancer-controller

Include target-type annotation in IngressClassParams

Open

#3,518 opened on Dec 26, 2023

View on GitHubContributor guide
 (13 comments) (3 reactions) (1 assignee)Go (1,644 forks)auto 404
good first issuekind/feature

Repository metrics

Stars
 (4,317 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Currently, the only way to set the target-type is through the Ingress annotation: alb.ingress.kubernetes.io/target-type: ip

This makes each declarative Ingress unnecessarily verbose even when using a custom IngressClass + IngressClassParams.

Describe the solution you'd like Include it as a spec parameter within the IngressClassParams.

Describe alternatives you've considered This can also be an annotation on the custom IngressClass.

Contributor guide

Research direction
Inspect the IngressClassParams type definition and the controller logic that resolves target type. Trace how the annotation is used currently, plan to add a spec field with validation, update the resolution order, and add test coverage.
Tech stack
gokubernetesaws
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGoKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75