kristijanhusak/laravel-form-builder

add new class name to choice type is not working properly

Open

#606 opened on Jul 10, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PHP (305 forks)github user discovery
help wanted

Repository metrics

Stars
 (1,715 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I want to add a new class required to input filed but it was not working as expected, there is no required class is added to input field.

->add('del_flg', Field::CHOICE, [
                'label' => '削除状態',
                'choices' => ['0' => '有効', '1' => '削除済'],
                'expanded' => true,
                'multiple' => false,
                'attr' => ['class' => 'required'],
                'choice_options' => [
                    'wrapper' => ['class' => 'choice-wrapper'],
                    'label_attr' => ['class' => 'required label-class'],
                ],
            ])

Contributor guide

Research direction
Trace the handling of 'attr' for choice fields in the form builder to see where the class is lost.
Tech stack
phplaravel
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPLaravel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65