kgrzybek/modular-monolith-with-ddd

Wrong comparison operator

Open

#197 opened on Apr 23, 2021

View on GitHub
 (1 comment) (2 reactions) (0 assignees)C# (2,184 forks)batch import
buggood first issue

Repository metrics

Stars
 (13,951 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/kgrzybek/modular-monolith-with-ddd/blob/54d209639e501301e879aa0d0a84c9ea49e4689e/src/Modules/Meetings/Domain/Meetings/Rules/MeetingAttendeesLimitMustBeGreaterThanGuestsLimitRule.cs#L1-L21

I believe the comparison operator used in the IsBroken method is wrong because the rule is checking that meeting attendees limit must be greater than guests limit.

Contributor guide

Research direction
Review the comparison operator in the MeetingAttendeesLimitMustBeGreaterThanGuestsLimitRule.cs file at the specified line and confirm if it should be '>' instead of the current operator.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Domain Driven Design basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75