keep-starknet-strange/madara-tsukuyomi

Check if docker is installed before starting the Apps

Open

#19 opened on Aug 17, 2023

 (10 comments) (0 reactions) (1 assignee)TypeScript (16 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (21 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now, the Apps section assume Docker is already installed and try to pull and run the app if the user interacts with it. However, this maybe not be true since the people using the app are non devs. Hence, we want a feature to check if Docker is installed or not and accordingly install it.

User flow

  1. User clicks on the Apps section
  2. renderer calls main to check if docker is installed
    • YES: move to step 3
    • NO: Give a message in full screen saying Docker is not installed and a once click button which installs it and shows the progress while installing. Start the docker daemon after installation.
  3. renderer calls main to check if daemon is running
    • YES: move to step 4
    • NO: Start the daemon
  4. Show the apps screen

Currently, we go directly from 1 -> 4 so the apps break if docker is not installed or the daemon isn't running.

Notes

  • In linux, starting the daemon is a simple one line command
  • In mac, starting the daemon isn't very simple and we can ideally use colima to abstract the complications. You can read more about that here
  • We will need to check how it works on Windows

Design

  • The design shouldn't be complicated for this and we can take inference from already existing components. If needed, I can make a sample screen as well.

Contributor guide