kairos-io/kairos

Make openrc override command logic generic for other services besides k3s

Open

#2,149 opened on Jan 15, 2024

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Go (133 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,782 stars)
PR merge metrics
 (Avg merge 2d 3h) (14 merged PRs in 30d)

Description

The openrc override command is done via the following function

https://github.com/kairos-io/kairos-sdk/blob/c21aa7f149cbbea5416f7fd475d9c6613d208d4e/machine/openrc/unit.go#L62

Unfortunately, this is too k3s specific, the command should work for any other service.

Contributor guide

Research direction
Examine the current implementation in machine/openrc/unit.go and identify the k3s specific parts. Propose a generic interface or function signature that accepts a service name parameter. Check how the override command is built and ensure it can be reused for other services without hardcoding service names.
Tech stack
go
Domain
backendinfrastructuredevops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70