jupyterlab/jupyterlab

Update `examples` folder to include localization.

Closed

#8,828 opened on Aug 13, 2020

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)TypeScript (2,937 forks)batch import
good first issuemaintenancetag:Examples

Repository metrics

Stars
 (13,454 stars)
PR merge metrics
 (Avg merge 16d 4h) (86 merged PRs in 30d)

Description

Task

After the localization work, the examples folder kept working as expected but the code does not make active use of localization.

In order to promote localizable code, it would be great to be able to showcase the bundled examples following the translation pattern.

Proposed Solution

Update the code in the examples folder to use an actual ITranslator (instead of the nullTranslator that is provided under the hood, and does nothing)

Additional context

Ping me for questions!

Contributor guide

Research direction
Familiarize with the JupyterLab localization system (ITranslator interface and nullTranslator). Then update each example in the examples folder to import and use an actual ITranslator instance instead of nullTranslator. Ensure that the translation function is used for user visible strings.
Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70