jsx-eslint/eslint-plugin-react

react/jsx-no-useless-fragment false positive

Open

#2,584 opened on Mar 3, 2020

 (15 comments) (23 reactions) (0 assignees)JavaScript (2,734 forks)batch import
help wanted

Repository metrics

Stars
 (9,294 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There's a false positive on the rule with forwarded children. Use cases are pretty rare but still exist. Without a fragment around the children, code breaks at runtime

const HollowComponent = ({ children }) => {
  // some logic here
  return <>{children}</>; // doesn't pass the rule
}

example: https://codesandbox.io/s/icy-lake-ri3uo

Temporary fix is to disable rule for this line but it would be nicer if this rule let this kind of Fragment use possible.

Contributor guide