jsx-eslint/eslint-plugin-react

warn when using setState in constructor

Open

#2,371 opened on Aug 5, 2019

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,734 forks)batch import
acceptedhelp wantednew rule

Repository metrics

Stars
 (9,293 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Obviously it could have been used by functions called from the constructor, but using setState in constructor is always an issue in react and causes a warning in debug mode.

Contributor guide

Research direction
Study existing ESLint rules in this plugin, especially those that detect lifecycle methods or state mutations. Look at the AST node for ClassBody and constructor to check for setState calls. Consider using the rule util functions for detecting React components.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75