josdejong/jsoneditor

Autocompletion: supporting self references

Open

#1,450 opened on Jul 7, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,080 forks)batch import
bughelp wanted

Repository metrics

Stars
 (12,263 stars)
PR merge metrics
 (Avg merge 15h 36m) (3 merged PRs in 30d)

Description

Hi,

Look like self references are not supported by the schema autocompletion feature. For example, on self key in the example below:

   {
        "type": "object",
        "properties": {
            "self": {
                "$ref": "#"
            },
            "bar": {
                "type": "string",
                "enum": [
                    "A",
                    "B"
                ]
            }
        },
        "additionalProperties": false
    }

Contributor guide

Research direction
Examine the autocompletion logic in the codebase, specifically how schema references are resolved. Look for existing handling of $ref and determine why self references (e.g., "$ref": "#") are not processed. Check if there is a recursion guard missing.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptJSON Schema
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55