jonkemp/inline-css

Wrong Css Gradient Inlining

Open

#52 opened on Sep 21, 2016

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (79 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (438 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello!

This code: .class { background: -webkit-linear-gradient(-45deg, #306ab2 0%, #00e1ed 70%, #00e1ed 70%); }

Inlines like a: <div class="class" style="background: -webkit-linear-gradient(-45deg, #306ab20%, #00e1ed70%, #00e1ed70%);">Some content</div>

We losing "spaces" between color hashes and percent values.

Contributor guide

Research direction
Examine the CSS parsing code to find where spaces between color values and percentages in gradients are being removed. Look for regex or string manipulation that might be stripping whitespace inside the gradient function arguments.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85