jonkemp/inline-css

Selector specificity not working for !important rules

Open

#32 opened on Mar 14, 2016

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)JavaScript (79 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (438 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When two selectors match the same element, and both have !important, then the selector specificity is ignored and the last rule wins:

inlineCss('<style>p a {color: red!important} a{color: black!important}</style>  <p><a>test', {url: '/'}).then(s=>console.log(s))
// '<p><a style="color: black;">test</a></p>'
inlineCss('<style>a{color: black!important} p a {color: red!important}</style>  <p><a>test', {url: '/'}).then(s=>console.log(s))
// '<p><a style="color: red;">test</a></p>'

However for the browsers it’s different. No matter which rule goes first, if both have !important in them, the more specific wins.

Contributor guide

Research direction
Investigate how inline css handles !important rules and selector specificity. Trace the code path that resolves conflicting styles, particularly where both rules have !important. Compare with browser behavior.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70