jeremyjh/dialyxir

Update PLT when child dependencies change

Open

#232 opened on Aug 16, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Elixir (160 forks)batch import
help wanted

Repository metrics

Stars
 (1,794 stars)
PR merge metrics
 (Avg merge 122d 13h) (1 merged PR in 30d)

Description

Happens with Elixir 1.7.2 and Dialyxir 0.5.1

  • I have an umbrella project with several child projects;

  • The umbrella and the child projects have the following in their mix.exs files (and nothing else regarding dialyxir):

defp deps do
    [
      ...
      {:dialyxir, "~> 0.5", only: [:dev, :test]}
      ...
    ]
end
  • Added a new dependency in one of the child projects (this dependency did not exist before in any child project).

Then,

Observed behavior: running mix dialyzer inside the child project does not update the PLT, but running the same command at the umbrella project updates the PLT.

Expected behavior: when child dependencies change, running mix dialyzer inside the corresponding child project, or running at the umbrella project, should update the PLT. The PLT check should always run, unless mix dialyzer --no-check is run.

Contributor guide

Research direction
Investigate how dialyxir determines whether to update the PLT when child dependencies change, focusing on the umbrella project structure and the `mix dialyzer` task.
Tech stack
elixir
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Elixirmix
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65