jazzband/django-silk

SILKY_ANALYZE_QUERIES=True causes unexpected data updates

Closed

#629 opened on Nov 15, 2022

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)Python (319 forks)batch import
documentationgood first issue

Repository metrics

Stars
 (3,958 stars)
PR merge metrics
 (Avg merge 4h 49m) (1 merged PR in 30d)

Description

Hi! First of all thanks for creating this library!

I have a case where I increment an integer like this: MyModel.objects.filter(pk=101).update(counter=F('counter')+1)

When using silk with SILKY_ANALYZE_QUERIES=True - my counter is incremented twice for every sql statement I make. This is probably not a bug, but I suggest to put a big warning in the docs, so that people use this setting with caution.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.