jaywcjlove/react-hotkeys

Command key doesn't repeat as expected

Open

#29 opened on Jan 8, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (22 forks)github user discovery
dependenciesenhancementhelp wanted

Repository metrics

Stars
 (442 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When the command key is used as a modifier it doesn't seem to allow other shortcuts to fire until the command key has been lifted again.

See example: https://codepen.io/stevenlundyseesaw/pen/LYEdVBL?editors=0010 Command left and right should move the circle left and right without having to lift the command key If you change it to another modifier (alt, shift) it works as expected

Contributor guide

Research direction
Investigate how the command key is handled as a modifier in the key event listeners. Check if the keydown event for the command key is preventing subsequent keydown events for other keys from firing. Look into the platform specific handling of modifier keys (especially on macOS) and ensure that the command key's 'sticky' behavior is not causing the issue.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65