jaredpalmer/after.js

Razzle as dev dependency?

Open

#419 opened on Jan 10, 2021

View on GitHubContributor guide
 (5 comments) (4 reactions) (0 assignees)TypeScript (195 forks)github user discovery
after.jsgood first issue

Repository metrics

Stars
 (4,090 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

🚀 Feature request

All Razzle examples use Razzle package as dev dependency. Except AfterJS - it needs Razzle as regular dependency because of razzle-dev-utils.

Current Behavior

If Razzle stays as a dev dep, I get this error message in production build:

Error: Cannot find module 'razzle-dev-utils/logger'
 Require stack:
 -  /app/node_modules/@jaredpalmer/after/build/cjs/getAssets.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/render.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/index.js

Desired Behavior

I would like to add AfterJS to my Razzle based project without moving Razzle from dev to regular dependencies.

Suggested Solution

Is using razzle-dev-utils in AfterJS worth? Can it be replaced with something?

Contributor guide

Research direction
Investigate whether the dependency on razzle dev utils in AfterJS can be replaced with an alternative that does not require moving Razzle from dev to regular dependencies. Look into how razzle dev utils is used and if its functionality can be replicated or sourced differently.
Tech stack
typescriptreactnodejs
Domain
frontendbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsnpm or yarnReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65