jaegertracing/jaeger

[test] Flaky test TestPasswordFromFile in plugin/storage/es/factory_test.go

Open

#4,743 opened on Sep 10, 2023

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (2,326 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (18,974 stars)
PR merge metrics
 (Avg merge 5d 7h) (75 merged PRs in 30d)

Description

https://github.com/jaegertracing/jaeger/actions/runs/6134973238/job/16648278200?pr=4742#step:7:4523

One strange thing I noticed in the output that the very last logged request to the server was with Basic Auth string looking like the first password, not the second password, as if the request with the second password was made but then someone again made a request with the old one. I wonder if the es.Client object can continue sending pings to the server if it's not Close-ed (which we don't do).

Contributor guide

Research direction
Inspect the flaky test at plugin/storage/es/factory test.go and trace the password handling. Check if the es.Client sends pings that interfere with password changes. Consider closing the client properly.
Tech stack
goelasticsearch
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65