jackwener/maka-agent

flaky test: shell-run-manager secret redaction across a soft wrap

Open

#2,978 opened on Aug 13, 2026

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)TypeScript (0 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

redacts a secret across a soft wrap and the scrollback/screen boundary in packages/runtime/src/__tests__/shell-run-manager.test.ts fails intermittently on CI.

Observed: run 31716295489, test_workspaces. The case failed at 27.6ms; the enclosing ShellRunProcessManager suite took 8.1s. It surfaced on #2962, which touches only packages/runtime-host/src/client and packages/eval and does not change packages/runtime at all. main was green at the time. Running the case alone locally passes in 549ms.

Suspected cause: the assertion depends on when the PTY flushes across the soft-wrap and scrollback/screen boundary, which shifts under CI load. The fix is to wait for a settled terminal state rather than a particular flush ordering.

This is not a redaction defect — the production behaviour under test looks correct; only the test's timing assumption is unsound.

Contributor guide

Research direction
Investigate the flaky test 'redacts a secret across a soft wrap and the scrollback/screen boundary' in packages/runtime/src/ tests /shell run manager.test.ts. Reproduce the intermittent failure on CI, then update the test to wait for a stable terminal state rather than a specific flush order.
Tech stack
typescript
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75