ipfs/kubo

secp256k1 key support is missing pem-pkcs8-cleartext import/export

Closed

#9,912 opened on May 31, 2023

View on GitHubContributor guide
 (6 comments) (1 reaction) (0 assignees)Go (2,725 forks)batch import
P2good first issuehelp wantedkind/bug

Repository metrics

Stars
 (13,906 stars)
PR merge metrics
 (Avg merge 4d 2h) (28 merged PRs in 30d)

Description

Seems https://github.com/ipfs/kubo/pull/9830 was missing a test for --format :)

cc @Jorropo @imthe1

Installation method

built from source

Version

0.20.0-dev

Description

$ ipfs key gen --type=secp256k1 key_secp256k1
$ ipfs key export key_secp256k1 -f pem-pkcs8-cleartext --output key.pem
Error: marshalling key to PKCS8 format: x509: unknown key type while marshaling PKCS#8: *crypto.Secp256k1PrivateKey

Contributor guide

Research direction
Identify the marshalling function for PKCS8 in the codebase, and add support for `secp256k1` keys by implementing the corresponding marshal method, similar to how other ECDSA keys are handled.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60