ionic-team/ionic-framework

Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter

Open

#30,422 opened on May 25, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (13,381 forks)batch import
help wantedionfw-internship-2025type: feature request

Repository metrics

Stars
 (52,503 stars)
PR merge metrics
 (Avg merge 4d 6h) (50 merged PRs in 30d)

Description

Currently, any time ion-toolbar changes in appearance, a lot of screenshots have to be updated. Most of them are only being updated because they include ion-toolbar for labeling the test; the change in them doesn’t matter because the test isn’t meant to verify the look of the toolbar.

The following groups of tests should be updated so that the test does not include the toolbar, since it doesn’t make sense to test the toolbar as part of the screenshot test in them:

  • badge-basic
  • button
  • item
  • list-header
  • progress-bar
  • searchbar
  • toast
  • toggle

Some of these might have one or two tests where ion-toolbar is used in the component they’re testing, but most of them do not, and all of the components listed here have tests that need to be updated to be refocused so they don’t include the ion-toolbar in the screenshot capture.

Contributor guide