influxdata/telegraf

Add retry feature for http secret-store plugin

Open

#15,846 opened on Sep 5, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (5,836 forks)batch import
feature requesthelp wantedsize/l

Repository metrics

Stars
 (17,753 stars)
PR merge metrics
 (Avg merge 2d 12h) (136 merged PRs in 30d)

Description

Use Case

Use the scretstore http plugin to retrieve connection information from postgresql output. However, in the current situation, if the secretstore http plugin fails to retrieve the API value, the service does not start because @ variable substitution is not performed.

Expected behavior

  • API call setup : Use @ variable
  • API connection failure : Retry

Actual behavior

  • API call setup : Use @ variable
  • API connection failure : service down ( The reason is that the @ variable does not have a value and attempts to connect in an unsubstituted state.)

Additional info

[[secretstores.http]]
  id = "meta"
  url = "http://localhost/meta"
  timeout = "5s"
  
[[outputs.postgresql]]
  connection = "host=@{meta:host} port=@{meta:port} user=@{meta:user} password=@{meta:password} dbname=@{meta:database} sslmode=disable"

Contributor guide

Research direction
Examine the http secret store plugin implementation to understand how secrets are retrieved and where failures occur. Then design a retry mechanism with configurable retries and backoff, ensuring that variable substitution only proceeds after successful retrieval.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75