imsnif/diskonaut

Bug: when deleting a folder that contains a file we can't delete, we get an uninformative message

Open

#11 opened on Jun 17, 2020

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Rust (93 forks)github user discovery
good first issuehelp wanted

Repository metrics

Stars
 (3,066 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

To reproduce:

  1. Create folder /path_to_my/folder
  2. Create nested_folder /path_to_my/folder/nested_folder
  3. Create a file inside nested_folder /path_to_my_folder/folder/nested_folder/file.txt
  4. Change the permissions of nested_folder to be read only.
  5. Start diskonaut and give it /path_to_my as its path (diskonaut /path_to_my).
  6. Try to delete folder.
  7. See that we get an uninformative error message and are unsure what happened.

In this scenario, the message should read something like "Permission denied deleting /path_to_my/folder/nested_folder".

Contributor guide

Research direction
Inspect the error handling code when deleting folders to add the full path of the failing directory to the error message.
Tech stack
rust
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75