import-js/eslint-plugin-import

Request: option to let `no-duplicates` force type & normal imports to be de-duplicated

Open

#909 opened on Aug 4, 2017

View on GitHubContributor guide
 (9 comments) (5 reactions) (0 assignees)JavaScript (1,549 forks)batch import
enhancementflowhelp wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

#225 asked to allow both type & normal imports to be allowed together, e.g.

import {someFunction} from '../src/foo';
import type {someType} from '../src/foo';

This was requested because according to the author there was no way to merge these together at that point in time.

However, currently flow does support merging these imports together:

import { someFunction, type someType } from '../src/foo';

I think it would therefore be useful if no-duplicates could be configured to have the same behaviour as before #225, i.e. to require type & normal imports to be merged.

Contributor guide

Research direction
Examine the no duplicates rule implementation and its tests, especially how type imports are currently handled. Look for the existing option that allows both type and normal imports to coexist, and understand the current behavior. Then implement a new option to force merging them.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLintFlow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65